Skip to content

Port regression test 433 to Pytests #3517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
heplesser merged 7 commits into from
Nov 24, 2025
Merged

Port regression test 433 to Pytests #3517

heplesser merged 7 commits into from
Nov 24, 2025

Conversation

@jessica-mitchell
Copy link
Contributor

@jessica-mitchell jessica-mitchell commented Jun 25, 2025

using Cursor AI

@jessica-mitchell jessica-mitchell added the S: Normal Handle this with default priority label Jun 25, 2025
@jessica-mitchell jessica-mitchell added T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jun 25, 2025
@github-project-automation github-project-automation bot moved this to In progress in PyNEST-NG Jun 25, 2025
@github-actions
Copy link

github-actions bot commented Aug 25, 2025

Pull request automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Aug 25, 2025
@github-actions github-actions bot removed the stale Automatic marker for inactivity, please have another look here label Nov 8, 2025
@terhorstd terhorstd requested a review from shimoura November 11, 2025 13:14
@jessica-mitchell
Copy link
Contributor Author

jessica-mitchell commented Nov 12, 2025

@heplesser I have a recurring failing test in the CI for several of these PRs related to the mpi test test_consistent_local_vps

FAILED result/share/nest/testsuite/pytests/mpi/4/test_consistent_local_vps.py::test_consistent_local_vps - unittest.case.SkipTest: NEST was compiled without multi-threading

A suggestion from AI was to switch the skip logic from @unittest.skipIf(not HAVE_OPENMP, "NEST was compiled without multi-threading") to @pytest.skipif . . . but I guess that might cause unittest to fail. Any thoughts on this?

@heplesser
Copy link
Contributor

heplesser commented Nov 12, 2025

@heplesser I have a recurring failing test in the CI for several of these PRs related to the mpi test test_consistent_local_vps

FAILED result/share/nest/testsuite/pytests/mpi/4/test_consistent_local_vps.py::test_consistent_local_vps - unittest.case.SkipTest: NEST was compiled without multi-threading

A suggestion from AI was to switch the skip logic from @unittest.skipIf(not HAVE_OPENMP, "NEST was compiled without multi-threading") to @pytest.skipif . . . but I guess that might cause unittest to fail. Any thoughts on this?

Fixed in master now (see #3629), please merge master into all open PRs.

@terhorstd terhorstd added the focus Issue/PR is part of the focused group of items in an ongoing coordinated effort. label Nov 14, 2025
@heplesser heplesser merged commit 88b1f9b into nest:master Nov 24, 2025
53 of 54 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in PyNEST-NG Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shimoura shimoura shimoura approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@heplesser heplesser

Labels

focus Issue/PR is part of the focused group of items in an ongoing coordinated effort. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.

Projects

PyNEST-NG
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jessica-mitchell @heplesser @shimoura @terhorstd